[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] Unlimited Loop: Null icon



On Sat, Dec 09, 2006 at 09:42:41PM -0700, David wrote:
> Situation:
> 
> I was changing the icons in my Ibar, and the only way to get updates
> to the same PNG file to show in the Ibar, I would have to change the
> filename of the icon to something else, apply it, then change it back
> to the file I had just updated. Instead of selecting a different file,
> I checked "Use Icon Theme" from the advanced options, applied that
> ---- This is where it freezes. If there is no icon in the icon theme,
> E goes into an infinite loop and effectively freezes. There was no
> icon because the app I was changing was Ephoto, which I had just
> compiled.
> 
> Even though users shouldn't be setting NULL values for icons, wouldn't
> it be good to add a conditional: "if (icon == NULL) { icon =
> "/path/to/unknown_icon.png"; }
> Forgive my php syntax, lol. I don't know C. I also wasn't able to read
> any of the code that was causing this, because I don't know where it
> is or how to interpret this backtrace much at all. I just assumed some
> things.
> 
> I hope this helps.

A version of a fix is committed, but it had a different bt, which makes
me suspect an out of date E.

Testing appreciated :)

metrics