[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] e_modules net and wlan fixes

Am Mittwoch, den 06.12.2006, 03:29 +1000 schrieb David Seikel:
> On Fri, 01 Dec 2006 18:32:41 +0100 "Stark, Thomas" <e-devel@st4rk.de>
> wrote:
> > attached you will find two patches. One will fix the net module
> > (change of the calculation base, because the unit of ci->max is
> > packets not bytes)
> I don't think that your code, or the original code is correct.
You are right. The calculation is totally bogus. Don't know what I
thought when I implemented it. :(

> The net module is trying to show a speedometer bar, so we need to know
> the maximum speed in order to  be able to determine which percentage of
> the maximum speed, and therefore which percentage of the maximum sized
> bar to show.  ci->max is the MTU (Maximum Transfer Unit), which is the
> maximum size a single packet can be, and not at all related to how fast
> those packets travel.  There is no system provided number that you can
> look at to find out the maximum speed of any particular network
> interface, as the speed is likely capped at the ISPs equipment.  The
> best you can do is to either track the fastest speed through the
> interface, or ask the user what speed they are supposed to be getting.
I vote for the solution asking the user which link speed he have. Maybe
we can change the MUT slider to a "scaling factor" slider (from 1 to 100
for example) and multiply the value to the real bytes per second, so you
can adjust the indication amplitude as you wish.

Btw, thanks for looking at my patches.


> I eventually want to replace all these system monitoring modules with
> some common code that resembles the way that gkrellm handles graphs.
> I'm not hearing anyone complain about the net module, so I'll leave
> well enough alone for now.
> Your other patch was useful though, and I applied part of it.
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 Stark, Thomas <thomas@st4rk.de>