[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] Pager patch



On Thu, 23 Nov 2006 00:24:02 +0200 Виктор Кожухаров <vkojouharov@gmail.com>
babbled:

> В нд, 2006-11-19 в 17:44 +0900, Carsten Haitzler написа:
> > On Thu, 16 Nov 2006 20:41:41 +0100 lok <heka.lok@gmail.com> babbled:
> > 
> > > On Thu, 16 Nov 2006 19:40:58 +0100
> > > lok <heka.lok@gmail.com> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > I've made some changement on the pager config.
> > > > The first one let the user choose the mouse button he wants for the two
> > > > type of drag.
> > > > And the second disable the wheel callback on the pager. The wheel
> > > > callback on the pager works only if the pager is in a shelf "above
> > > > everything". By default it's disabled because scrolling above the pager
> > > > in this case make you switch by a step of 2 desktops (one is done by
> > > > the pager's callback and the other by the E's default mousebinding).
> 
> can we revert this part, about removing the wheel callback. With the
> default mouse bindings NOT having the mouse wheel bound to desktop
> change, there's really no other way to _just_ change the desks with the
> wheel. and since that's the default, there are a lot more people who
> can't use the wheel for desk change, than there are people who can.

the default is NOT to use the wheel on the desktop to change - that WAS the
default at some stage. the patch is ok - except for a bug where you can't
properly set the button for drag modes.

> > > > 
> > > > The pager is probably the most used module, so I prefere to not commit
> > > > this patch directly. (just to be sure to not be hunt down if I've made
> > > > a mistake). And the patch also fix a small warning.
> > > > 
> > > > Lok
> > > 
> > > ok sorry about the double posting. 
> > > I forgot to change two values before making the patch.
> > > This one is the good one. (No need to apply the previous)
> > 
> > sounds good - note though - the default removed the wheel bindings for the
> > desktop so if you started from fresh config it wouldnt jump 2 desks.
> > 
> -- 
> Виктор Кожухаров /Viktor Kojouharov/
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    raster@rasterman.com
裸好多
Tokyo, Japan (東京 日本)