[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[E-devel] [PATCH]'s Mem Leaks in ecore_x_fixes.c, e_manager.c, bling



Results from a valgrind run revealed the following leaks, resulting in
the following patches for ecore_x_fixes.c, e_manager.c and e_mod_main.c
in bling.

metrics
Index: ecore_x_fixes.c
===================================================================
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_x/ecore_x_fixes.c,v
retrieving revision 1.2
diff -u -r1.2 ecore_x_fixes.c
--- ecore_x_fixes.c	19 May 2006 15:02:54 -0000	1.2
+++ ecore_x_fixes.c	27 Oct 2006 05:34:00 -0000
@@ -73,6 +73,7 @@
 
    xrect = _ecore_x_rectangle_ecore_to_x(rects, num);
    region = XFixesCreateRegion(_ecore_x_disp, xrect, num);
+   free(xrect);
    return region;
 #else
    return 0;
Index: e_manager.c
===================================================================
RCS file: /var/cvs/e/e17/apps/e/src/bin/e_manager.c,v
retrieving revision 1.57
diff -u -r1.57 e_manager.c
--- e_manager.c	21 Oct 2006 10:52:43 -0000	1.57
+++ e_manager.c	27 Oct 2006 05:32:25 -0000
@@ -205,9 +205,9 @@
 	       }
 	     if (data)
 	       {
-		  continue;
 		  free(data);
 		  data = NULL;
+		  continue;
 	       }
 	     ret = ecore_x_window_prop_card32_get(windows[i],
 						  E_ATOM_MANAGED,
Index: e_mod_main.c
===================================================================
RCS file: /var/cvs/e/e_modules/bling/e_mod_main.c,v
retrieving revision 1.6
diff -u -r1.6 e_mod_main.c
--- e_mod_main.c	3 Jul 2006 20:19:20 -0000	1.6
+++ e_mod_main.c	27 Oct 2006 05:34:50 -0000
@@ -234,6 +234,7 @@
       ecore_idle_enterer_add(_bling_composite_restart, b);
    else if (!composite_init(b))
    {
+      E_CONFIG_DD_FREE(b->conf_edd); 
       E_FREE(b);
       return NULL;
    }