[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: apps/e devilhorns



Devilhorns, 

I see that you are using class names which are very specific like cpufreq_label and battery_label.  This will cause an issue for third party modules not being able to use color classes.  I think its best that class names be generic to modules as a whole and not specific functions. 

Consider class names like
  mod_label
  mod_title
  mod_text

Most of the labels look good.  Another option would be for enabling third party modules to extend the available color/font class lists dynamically. 

Thats just my opinion though, 

-Stafford

On Thu,  5 Oct 2006 22:25:57 -0400 (EDT)
Enlightenment CVS <noreply@cvs.enlightenment.org> wrote:

> Enlightenment CVS committal
> 
> Author  : devilhorns
> Project : e17
> Module  : apps/e
> 
> Dir     : e17/apps/e/data/themes
> 
> 
> Modified Files:
> 	default_battery.edc default_cpufreq.edc default_entry.edc 
> 	default_error.edc default_ibox.edc default_radio.edc 
> 	default_slider.edc default_temperature.edc 
> 	default_theme_about.edc 
> 
> 
> Log Message:
> Added more color classes.
> 
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_battery.edc,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -3 -r1.12 -r1.13
> --- default_battery.edc	28 Sep 2006 06:07:15 -0000	1.12
> +++ default_battery.edc	6 Oct 2006 02:25:57 -0000	1.13
> @@ -159,6 +159,7 @@
>  	    color: 255 255 255 255;
>  	    color2: 0 0 0 128;
>  	    color3: 0 0 0 32;
> +	    color_class: "battery_label";
>  	    text {
>  	       text:     "100%";
>  	       font:     "Edje-Vera-Bold";
> @@ -189,6 +190,7 @@
>  	    color: 255 255 255 255;
>  	    color2: 0 0 0 128;
>  	    color3: 0 0 0 32;
> +	    color_class: "battery_label";
>  	    text {
>  	       text:     "00:00";
>  	       font:     "Edje-Vera-Bold";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_cpufreq.edc,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -3 -r1.8 -r1.9
> --- default_cpufreq.edc	28 Sep 2006 06:07:15 -0000	1.8
> +++ default_cpufreq.edc	6 Oct 2006 02:25:57 -0000	1.9
> @@ -304,6 +304,7 @@
>  	    color: 255 255 255 255;
>  	    color2: 0 0 0 128;
>  	    color3: 0 0 0 32;
> +	    color_class: "cpufreq_label";
>  	    text {
>  	       text: "??? Ghz";
>  	       font: "Edje-Vera-Bold";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_entry.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_entry.edc	23 Aug 2006 08:53:25 -0000	1.13
> +++ default_entry.edc	6 Oct 2006 02:25:57 -0000	1.14
> @@ -86,6 +86,7 @@
>  	 description {
>  	    state: "default" 0.0;
>  	    color: 0 0 0 255;
> +	    color_class: "entry_text";
>  	    text {
>  	       text: "Entry";
>  	       font: "Edje-Vera";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_error.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_error.edc	23 Aug 2006 03:39:01 -0000	1.13
> +++ default_error.edc	6 Oct 2006 02:25:57 -0000	1.14
> @@ -122,6 +122,7 @@
>  	    }
>  	    color:    0   0   0 255;
>  	    color3: 255 255 255 128;
> +	    color_class: "error_title";
>  	    text {
>  	       text:     "Title";
>  	       font:     "Edje-Vera-Bold";
> @@ -213,6 +214,7 @@
>  	    }
>  	    color:    0   0   0 255;
>  	    color3: 255 255 255 128;
> +	    color_class: "button_text";
>  	    text {
>  	       text:     "OK";
>  	       font:     "Edje-Vera";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_ibox.edc,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -3 -r1.4 -r1.5
> --- default_ibox.edc	23 Aug 2006 03:39:01 -0000	1.4
> +++ default_ibox.edc	6 Oct 2006 02:25:57 -0000	1.5
> @@ -212,6 +212,7 @@
>  	    }
>  	    color: 255 255 255 0;
>  	    color3: 0 0 0 0;
> +	    color_class: "ibox_label";
>  	    text {
>  	       text: "Icon Name";
>  	       font: "Edje-Vera-Bold";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_radio.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_radio.edc	23 Aug 2006 03:39:01 -0000	1.13
> +++ default_radio.edc	6 Oct 2006 02:25:57 -0000	1.14
> @@ -81,6 +81,7 @@
>  	    }
>  	    color: 0 0 0 255;
>  	    color3: 255 255 255 128;
> +	    color_class: "radio_text";
>  	    text {
>  	       text:     "Radio Button";
>  	       font:     "Edje-Vera";
> @@ -95,6 +96,7 @@
>  	    inherit:  "default" 0.0;
>  	    color:    0   0   0 128;
>  	    color3: 255 255 255 64;
> +	    color_class: "radio_text_disabled";
>  	 }
>        }
>        part {
> @@ -337,6 +339,7 @@
>  	    }
>  	    color: 0 0 0 255;
>  	    color3: 255 255 255 128;
> +	    color_class: "radio_text";
>  	    text {
>  	       text:     "";
>  	       font:     "Edje-Vera";
> @@ -351,6 +354,7 @@
>  	    inherit:  "default" 0.0;
>  	    color:    0   0   0 128;
>  	    color3: 255 255 255 64;
> +	    color_class: "radio_text_disabled";
>  	 }
>        }
>        part {
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_slider.edc,v
> retrieving revision 1.14
> retrieving revision 1.15
> diff -u -3 -r1.14 -r1.15
> --- default_slider.edc	6 Sep 2006 22:26:19 -0000	1.14
> +++ default_slider.edc	6 Oct 2006 02:25:57 -0000	1.15
> @@ -116,6 +116,7 @@
>  	       offset:   -8  -8;
>  	    }
>  	    color: 0 0 0 255;
> +	    color_class: "slider_text";
>  	    text {
>  	       text:     "00.00";
>  	       font:     "Edje-Vera";
> @@ -529,6 +530,7 @@
>  	       offset:   -8  -8;
>  	    }
>  	    color: 0 0 0 255;
> +	    color_class: "slider_text";
>  	    text {
>  	       text:     "00.00";
>  	       font:     "Edje-Vera";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_temperature.edc,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -3 -r1.9 -r1.10
> --- default_temperature.edc	28 Sep 2006 06:07:15 -0000	1.9
> +++ default_temperature.edc	6 Oct 2006 02:25:57 -0000	1.10
> @@ -86,6 +86,7 @@
>  	    color: 255 255 255 255;
>  	    color2: 0 0 0 128;
>  	    color3: 0 0 0 32;
> +	    color_class: "temperature_label";
>  	    text {
>  	       text:     "99^C";
>  	       font:     "Edje-Vera-Bold";
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/data/themes/default_theme_about.edc,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -u -3 -r1.7 -r1.8
> --- default_theme_about.edc	23 Aug 2006 14:16:34 -0000	1.7
> +++ default_theme_about.edc	6 Oct 2006 02:25:57 -0000	1.8
> @@ -293,6 +293,7 @@
>  	    }
>  	    color:    0   0   0 255;
>  	    color3: 255 255 255 128;
> +	    color_class: "button_text";
>  	    text {
>  	       text:     "OK";
>  	       font:     "Edje-Vera";
> 
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> enlightenment-cvs mailing list
> enlightenment-cvs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
> 


-- 
                        Stafford M. Horne
Senior Engineer                                 高级工程师
SurfControl plc                                 美讯智科技
Peoples Republic of China, Beijing              中华人民共和国, 北京
Mobile: +86 13611014044                         手机:+86 13611014044

          (Website) http://blog.shorne-pla.net/ (网站)