[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: apps/e titan



It might be. Eap editor has issues at the moment. That was just me trying to work in a way to close the fsel if eap editor closes, and if (fsel_dia) was always true even if the dialog wasn't visible.. so instead I did if(fsel) which is only true if the fsel is open.

On 8/27/06, brian.mattern@gmail.com <brian.mattern@gmail.com > wrote:
On Sun, Aug 27, 2006 at 01:33:19AM -0400, Enlightenment CVS wrote:
> Enlightenment CVS committal
>
> Author  : titan
> Project : e17
> Module  : apps/e
>
> Dir     : e17/apps/e/src/bin
>
>
> Modified Files:
>       e_eap_editor.c
>
>
> Log Message:
> Bad titan! Bad Bad Bad titan! No cookie! Fix the seg I left in :)
>
...

> -     if (data->editor->fsel_dia) e_object_del(E_OBJECT(data->editor->fsel_dia));
> +     if (data->editor->fsel) e_object_del(E_OBJECT(data->editor->fsel_dia));

I'm not sure I follow why this was changed. If the original version was
causing a segfault, then fsel_dia was freed without the pointer being
set to null. Are you sure this isn't just hiding a different issue?
--
rephorm


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



--
Stephen Houston