[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: apps/e titan



On Sun, Aug 27, 2006 at 01:33:19AM -0400, Enlightenment CVS wrote:
> Enlightenment CVS committal
> 
> Author  : titan
> Project : e17
> Module  : apps/e
> 
> Dir     : e17/apps/e/src/bin
> 
> 
> Modified Files:
> 	e_eap_editor.c 
> 
> 
> Log Message:
> Bad titan! Bad Bad Bad titan! No cookie! Fix the seg I left in :)
> 
...

> -	if (data->editor->fsel_dia) e_object_del(E_OBJECT(data->editor->fsel_dia));
> +	if (data->editor->fsel) e_object_del(E_OBJECT(data->editor->fsel_dia));

I'm not sure I follow why this was changed. If the original version was
causing a segfault, then fsel_dia was freed without the pointer being
set to null. Are you sure this isn't just hiding a different issue?
--
rephorm