[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: apps/e raster



On Wed, 16 Aug 2006 19:14:26 +0200 Simon TRENY <simon.treny@free.fr> babbled:

Hmmm - this is weird - that patch seems fine. it refcounts the border up -
spews out an event. unless the focus call is called from within the free func
for the border that is focused.... i addded an obj is del check and refcount
check before generating the event

> On Wed, 16 Aug 2006 16:13:13 +0200,
> Simon TRENY <simon.treny@free.fr> wrote :
> 
> > On Sat, 12 Aug 2006 23:37:23 -0400 (EDT),
> > Enlightenment CVS <noreply@cvs.enlightenment.org> wrote :
> > 
> > > Enlightenment CVS committal
> > > 
> > > Author  : raster
> > > Project : e17
> > > Module  : apps/e
> > > 
> > > Dir     : e17/apps/e/src/bin
> > > 
> > > 
> > > Modified Files:
> > > 	e_border.c 
> > > 
> > > 
> > > Log Message:
> > > 
> > > 
> > > focusout patch from sthitha
> > 
> > This patch makes e17 segfault when I drag an icon to a directory in
> > Rox Filer. I think it's because the "Move" window appears and
> > disappears really quickly. So I guess it happens when a window pops up
> > and pops down REALLY quickly.
> > 
> > Here is the backtrace:
> > http://rafb.net/paste/results/WQe3U182.html
> > and the valgrind log:
> > http://rafb.net/paste/results/VpdN5T35.html
> > (this warning is repeated at least 30 times)
> 
> Since the paste on rafb.net are deleted after 24 hours, I post the logs
> here:
> 
> - Backtrace:
> Program received signal SIGSEGV, Segmentation fault.
> e_object_unref (obj=0x3a8) at e_object.c:99
> 99         obj->references--;
> (gdb) bt
> #0  e_object_unref (obj=0x3a8) at e_object.c:99
> #1  0x0807c1d9 in _e_border_free (bd=0x81365a0) at e_border.c:2989
> #2  0x080921a9 in e_object_unref (obj=0x3a8) at e_object.c:101
> #3  0x0807ac92 in _e_border_event_border_focus_out_free (data=0x0, 
>     ev=0x8179e28) at e_border.c:6650
> #4  0xb7e971b3 in _ecore_event_del (event=0x82f0f88) at
> ecore_events.c:356 #5  0xb7e97505 in _ecore_event_call () at
> ecore_events.c:444 #6  0xb7e9cbfe in _ecore_main_loop_iterate_internal
> (once_only=0) at ecore_main.c:639
> #7  0xb7e9cdff in ecore_main_loop_begin () at ecore_main.c:79
> #8  0x080651c7 in main (argc=1, argv=0xbfb3f804) at e_main.c:713
> 
> 
> - Valgrind log:
> ==4222== Invalid read of size 4
> ==4222==    at 0x8092298: e_object_unref (e_object.c:99)
> ==4222==    by 0x807ACA1: _e_border_event_border_focus_out_free
> (e_border.c:6650) ==4222==    by 0x40AE1B2: _ecore_event_del
> (ecore_events.c:356) ==4222==    by 0x40AE504: _ecore_event_call
> (ecore_events.c:444) ==4222==    by 0x40B3BFD:
> _ecore_main_loop_iterate_internal (ecore_main.c:639) ==4222==    by
> 0x40B3DFE: ecore_main_loop_begin (ecore_main.c:79) ==4222==    by 0x80651D6:
> main (e_main.c:713) ==4222==  Address 0x47EDB90 is 8 bytes inside a block of
> size 932 free'd ==4222==    at 0x401F199: free
> (in /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so) ==4222==    by
> 0x80922B8: e_object_unref (e_object.c:101) ==4222==    by 0x807AC71:
> _e_border_event_border_focus_in_free (e_border.c:6640) ==4222==    by
> 0x40AE1B2: _ecore_event_del (ecore_events.c:356) ==4222==    by 0x40AE504:
> _ecore_event_call (ecore_events.c:444) ==4222==    by 0x40B3BFD:
> _ecore_main_loop_iterate_internal (ecore_main.c:639) ==4222==    by
> 0x40B3DFE: ecore_main_loop_begin (ecore_main.c:79) ==4222==    by 0x80651D6:
> main (e_main.c:713)
> 
> 
> Simon
> 
> > 
> > 
> > Cheers,
> > Simon TRENY <MoOm>
> > 
> > > 
> > > ===================================================================
> > > RCS file: /cvs/e/e17/apps/e/src/bin/e_border.c,v
> > > retrieving revision 1.523
> > > retrieving revision 1.524
> > > diff -u -3 -r1.523 -r1.524
> > > --- e_border.c	12 Aug 2006 13:22:48 -0000	1.523
> > > +++ e_border.c	13 Aug 2006 03:37:23 -0000	1.524
> > > @@ -1351,11 +1351,20 @@
> > >       {
> > >  	if (focused)
> > >  	  {
> > > +	     E_Event_Border_Focus_Out *ev;
> > >  //	     printf("unfocus previous\n");
> > >  	     edje_object_signal_emit(focused->bg_object, "passive",
> > > ""); if (focused->icon_object)
> > >  	       edje_object_signal_emit(focused->icon_object,
> > > "passive", ""); e_focus_event_focus_out(focused);
> > > +
> > > +	     ev = calloc(1, sizeof(E_Event_Border_Focus_Out)); 
> > > +	     ev->border = focused; 
> > > +	     e_object_ref(E_OBJECT(focused));
> > > +
> > > +	     ecore_event_add(E_EVENT_BORDER_FOCUS_OUT, ev,
> > > +			     _e_border_event_border_focus_out_free,
> > > NULL); +
> > >  	     /* FIXME: Sometimes we should leave the window
> > > fullscreen! */ //	     if (focused->fullscreen)
> > > e_border_unfullscreen(focused); focused->focused = 0;
> > > 
> > > 
> > > 
> > > -------------------------------------------------------------------------
> > > Using Tomcat but need to do more? Need to support web services,
> > > security? Get stuff done quickly with pre-integrated technology to
> > > make your job easier Download IBM WebSphere Application Server
> > > v.1.0.1 based on Apache Geronimo
> > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > > _______________________________________________ enlightenment-cvs
> > > mailing list enlightenment-cvs@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
> > > 
> > 
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services,
> > security? Get stuff done quickly with pre-integrated technology to
> > make your job easier Download IBM WebSphere Application Server
> > v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________ enlightenment-devel
> > mailing list enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > 
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    raster@rasterman.com
裸好多
Tokyo, Japan (東京 日本)