[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: libs/ecore onefang



Enlightenment CVS wrote:
-/* FIXME: No unnecessary includes in exported headers. */
+/* FIXME: No unnecessary includes in exported headers, when things settle down and we know what is unnecessary. */
 #include <string.h>
+#include <strings.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
@@ -35,7 +36,7 @@
#define MAX_PATH 4096 -/* FIXME: No unnecessary macros in exported headers. */
+/* FIXME: No unnecessary macros in exported headers, when things settle down and we know what is unnecessary. */
 #define E_FN_DEL(_fn, _h) if (_h) { _fn(_h); _h = NULL; }
 #define E_REALLOC(p, s, n) p = (s *)realloc(p, sizeof(s) * n)
 #define E_NEW(s, n) (s *)calloc(n, sizeof(s))

There will _newer_ be a good reason for exporting these. The should be in an internal header.

Sebastian