[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] [ECORE][PATCH]Ecore Daemon



On Mon, 24 Jul 2006 20:58:27 +0100 Essien Ita Essien <essien@wazobialinux.com>
babbled:

a quick scan of the patch - coding style. we can argue forever which is
best/right/wrong - but we won't. follow the existing style. i.e.

int
func(int x)
{
  int y, z;
  
  y = 0;
  z = y;
  if (x) 
    {
      blah(x);
      blah(y);
    }

  if ((y == z) && (x))
    blah(z);
  return x;
}

etc.

see existing code. vim indent rules:

/*
 * vim:ts=8:sw=3:sts=8:noexpandtab:cino=>5n-3f0^-2{2
 */

:)

the reason for this is - it is hard to follow code when it keeps hanging style
as you read it - a consistent style maks it easier to follow - regardless of
the style itself :) choice of style is fairly arbitrary though, but that
choice was made a long time ago.
 
> Hiya all,
> 
> Doing some more cleanups in Entrance has led me to require a proper 
> daemon library in the EFL. After acertaining that none such existed, 
> I've ported a small library which i use for my personal coding to an 
> Ecore subsystem Ecore_Daemon.
> 
> The process I followed are outlined here: 
> http://www.linuxprofilm.com/articles/linux-daemon-howto.html
> 
> The patch contains the first incarnation of Ecore_Daemon after porting 
> it from my code to an Ecore subsystem. The patch also contains an 
> example in examples/daemon_example.c
> 
> Its a small contained body of code, so here we go.
> 
> The library is designed around ecore_daemon_daemonize(), which does all 
> the work. You can set params before calling daemonize, but you can just 
> use it as it is, as ecore_daemon_init() sets sane params for you already.
> 
> Please review [*hint* rephorm, handyande *end-hint* :D] and advice. 
> (Especially all them autoKUNGfoo. I tested it properly, but i'm not a 
> 3rd dan autoKUNGfoo practitioner so I may invariably break stuff?)
> 
> Once this is sorted out, I can get back to using it from within 
> Entrance. Makes things a whole lot more nicer.
> 
> Cheers,
> Essien
> 
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    raster@rasterman.com
裸好多
Tokyo, Japan (東京 日本)