[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] [ENTRANCE][PATCH] entrance_edit2



brian.mattern@gmail.com wrote:
On Fri, Jul 21, 2006 at 02:43:34AM +0100, Essien Ita Essien wrote:
NB: I have some other entrance minor cleanup patches I sent in earlier... no responses on those... i'll prolly send them again

I know I said before that I'd take a look at them, and I know I did and
they looked good for the most part. Somehow I got distracted and never
got them committed. I remember thinking the two functions for getting
the geometries could be combined into a single one (since they were
almost duplicate, and were called in succession iirc).
Yeah, that was my original intent, but i thought it an overkill to return a geometry struct, or returning values via passed in pointers (doesn't feel too natural) or even a two int array (like pipe() does).
rephorm

p.s. i'll try to take a look at the new patches you sent, but given my
track record, i don't want to promise too much :)


Hehe, fair enuff. I've sent xcomp a personal bugger mail ;), so somehow one of you guys will definitely look at it. In the meantime, i think i'll keep 'em coming, just that it would be more convenient to build on previously commited patches.

Essien
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel