[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[E-devel] e17 e_thumb patch



When using e17 thumbnailing functionnalities (e_thumb), i noticed 2
bugs :

   1) When thumbnailing is finished (the "to thumbnail" list is empty),
and then you launch thumbnailing again for new pictures, it doesnt work

   2) When you restart E while thumbnailing, you get a message like
_______                     _______
|:::::| Enlightenment Error |:::::|
~~~~~~~                     ~~~~~~~
Cannot create manager object for screen 0

_______                     _______
|:::::| Enlightenment Error |:::::|
~~~~~~~                     ~~~~~~~


Here is a little patch to fix at least the first point.
For the second one, i just kill (SIGTERM) the subprocess that creates
the thumbs, in e_thumb_shutdown. Actually thats not enought (sometimes
it doesnt work, maybe because the subprocess does not die
instantaneously).
I believe this problem can be fixed another way ...
but i don't know how =)


laurent 'kiwi'
--- e_thumb.c	2006-07-05 22:20:21.863373488 +0200
+++ NEWe_thumb.c	2006-07-05 22:16:56.246631984 +0200
@@ -66,6 +66,9 @@
 	event_handlers = evas_list_remove_list(event_handlers, event_handlers);
      }
    evas_list_free(thumb_files);
+
+   if (pid != -1)
+     kill(pid, SIGTERM);
    
    return 1;
 }
@@ -587,7 +590,11 @@
    
    ev = event;
    if (ev->pid != pid) return 1;
-   if (!thumb_files) return 1;
+   if (!thumb_files)
+     {
+        pid = -1;
+        return 1;
+     }
    
    t = thumb_files->data;
    thumb_files = evas_list_remove_list(thumb_files, thumb_files);