[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E CVS: apps/e devilhorns



Carsten Haitzler (The Rasterman) wrote:
> On Mon,  3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS
> <noreply@fitx-00.ewr.caosity.org> babbled:
> 
> What was the reasoning for this? why would one need to pass the path to an
> module icon explicitly? (if you want to do your own icon in a dialog for a
> different dialog you can always do the dialog by hand?)
> 
>> Enlightenment CVS committal
>>
>> Author  : devilhorns
>> Project : e17
>> Module  : apps/e
>>
>> Dir     : e17/apps/e/src/modules/temperature
>>
>>
>> Modified Files:
>> 	e_mod_config.c 
>>
>>
>> Log Message:
>> As per HandyAndE request, this patch gives ability for modules config
>> dialogs to show their icon in their config dialog by passing in the
>> module_eap path to the config_dialog_new function as the icon parameter ie:
>>
>> e_config_dialog_new(con, module_name, eap_path, 0, v, data);
>>
>> Update E core modules to use this ability.
>> Fix dropshadow config dialog to fit in 640x480.
>>
>> ===================================================================
>> RCS file: /cvs/e/e17/apps/e/src/modules/temperature/e_mod_config.c,v
>> retrieving revision 1.20
>> retrieving revision 1.21
>> diff -u -3 -r1.20 -r1.21
>> --- e_mod_config.c	7 Jun 2006 08:34:10 -0000	1.20
>> +++ e_mod_config.c	3 Jul 2006 07:35:44 -0000	1.21
>> @@ -44,6 +44,7 @@
>>  {
>>     E_Config_Dialog *cfd;
>>     E_Config_Dialog_View *v;
>> +   char buf[4096];
>>     
>>     v = E_NEW(E_Config_Dialog_View, 1);
>>     
>> @@ -53,9 +54,10 @@
>>     v->basic.create_widgets = _basic_create_widgets;
>>     v->advanced.apply_cfdata = _advanced_apply_data;
>>     v->advanced.create_widgets = _advanced_create_widgets;
>> -   
>> +
>> +   snprintf(buf, sizeof(buf), "%s/module.eap", e_module_dir_get
>> (temperature_config->module)); cfd = e_config_dialog_new
>> (e_container_current_get(e_manager_current_get()), 
>> -			     _("Temperature Configuration"), NULL, 0, v,
>> NULL);
>> +			     _("Temperature Configuration"), buf, 0, v,
>> NULL); temperature_config->config_dialog = cfd;
>>  }
>>  
>>
>>
>>
>> Using Tomcat but need to do more? Need to support web services, security?
>> Get stuff done quickly with pre-integrated technology to make your job easier
>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> _______________________________________________
>> enlightenment-cvs mailing list
>> enlightenment-cvs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>>
> 
> 
This was requested by Andy so that modules config dialogs could show
their icon in the border of their config dialogs. I think consistency
was his main goal and also so users can identify easily what config
dialog is for what module.

If it is a problem I can roll it back and change the modules back to
previous way of showing the E icon on the border of the config dialog.

dh