[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] Actions for window fullscreen

On Tue, 20 Jun 2006 21:07:29 +0530 "R.Ramkumar" <andyetitmoves@gmail.com>

> Hi!
> > well it's not a unified diff - so it'll have to be rejected (ie  a diff
> > with the +'s and -'s at the start of lines). also please attach diffs to
> > mails - not inline them :)
> Took the liberty of an inline cvs diff as it was meant only for
> viewing :) Sorry anyway... Here's the diff -Naur for e_actions.c
> against v1.70 attached..

ok - thanks. half the patch is in (the fullscreen toggle). i can't accept the
sock action patch as is

1. you aren't using handy existing socket api's like ecore_con.
2. as a result of this and lack of other infrastructure code - this action can
block/lock e if the other end of the socket doesn't listen or is hung and/or
the buffer fills up. the wm hanging like this is REALLY bad. this socket data
dump should be asynchronous and/or done in the background without the wm
hanging waiting for the data to write.

------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    raster@rasterman.com
Tokyo, Japan (東京 日本)