[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[E-devel] Valgrind support in Evas



Hi,
some time ago, Valgrind support was disabled in Evas.
IIRC it was because we applied the linker flags from "pkg-config --libs
valgrind", which broke the build.

I attached a patch that enables Valgrind support again, but doesn't
apply the libs (they are only needed when you're developing Valgrind
tools I think).

Can we get that in?

Regards,
Tilman

-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
Index: configure.in
===================================================================
RCS file: /cvs/e/e17/libs/evas/configure.in,v
retrieving revision 1.158
diff -u -p -r1.158 configure.in
--- configure.in	19 May 2006 09:27:33 -0000	1.158
+++ configure.in	21 May 2006 18:08:08 -0000
@@ -1694,31 +1694,31 @@ AC_ARG_ENABLE(convert-32-rgb-rot-90, 
 # Setting have_valgrind to "no" seems pointless, but we just need to
 # put something in as the 4th parameter, so configure doesn't abort
 # when valgrind.pc isn't found.
-#have_valgrind="no"
-#PKG_CHECK_MODULES(VALGRIND, valgrind >= 2.4.0, have_valgrind=yes, have_valgrind=no)
-#AC_ARG_ENABLE(valgrind,
-#  [  --enable-valgrind               enable valgrind fixes to stop false reports], [
-#      if test x"$enableval" = x"yes" ; then
-#        have_valgrind="yes"
-#      else
-#        have_valgrind="no"
-#        VALGRIND_CFLAGS=""
-#        VALGRIND_LIBS=""
-#      fi
-#  ], [
-#    have_valgrind=$have_valgrind
-#  ]
-#)
+have_valgrind="no"
+PKG_CHECK_MODULES(VALGRIND, valgrind >= 2.4.0, have_valgrind=yes, have_valgrind=no)
+VALGRIND_LIBS="" # dont use LIBS
 
-#if test x$have_valgrind = "xyes"; then
-#  AC_DEFINE(HAVE_VALGRIND, 1, [Valgrind support])
-#fi
+AC_ARG_ENABLE(valgrind,
+  [  --enable-valgrind               enable valgrind fixes to stop false reports], [
+      if test x"$enableval" = x"yes" ; then
+        have_valgrind="yes"
+      else
+        have_valgrind="no"
+        VALGRIND_CFLAGS=""
+      fi
+  ], [
+    have_valgrind=$have_valgrind
+  ]
+)
+
+if test x$have_valgrind = "xyes"; then
+  AC_DEFINE(HAVE_VALGRIND, 1, [Valgrind support])
+fi
 
 #####################################################################
 ## Fill in flags
 
 AC_SUBST(VALGRIND_CFLAGS)
-AC_SUBST(VALGRIND_LIBS)
 
 AC_SUBST(x_cflags)
 AC_SUBST(x_libs)

Attachment: pgpxX058aHto9.pgp
Description: PGP signature