[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [E-devel] E17 Shutup Compiler Warnings



Hi All, 

Let me make this proposal in another way. 

If anyone objects let me know, otherwise I will commit in a few days. Just doing some extra testing to make sure I don't break anything to badly. 

-Stafford

On Sat, 25 Feb 2006 19:14:18 +0800
Stafford Horne <shorne@softhome.net> wrote:

> Hi All, 
> 
> I have taken some times to fix a lot of compiler warning is E17.  Normally I would just submit the patch and wait for complaints, but this patch is rather large. I would like to see if anyone has any different approaches. This is what I have done:
> 
> Loads of work on:
> * All char * variables which are managed by stringshare have been changed to     
>   const char *.
> * All function parameters of type char * which are not changed by the funtion and 
>   in some cases duped by stringshare have been change to const char *
> 
> Small things:
> * Remove some unused variables
> * cleanup some missing includes
> * fix some places where stringshare variables were being freed
> 
> Results:
> The patch attached reduces compiler warnings significantly. There are still warnings in High-Development systems like a few config dialogs and fileman. 
> 
> I just expect a few people to look at the patch and say ok or don't do this then I can make changes and commit. me is not expecting people to apply the patch. 
> 
> -- 
> 			Stafford M. Horne
> 


-- 
			Stafford M. Horne
Senior Engineer                                 高级工程师
SurfControl plc                                 美讯智科技
Peoples Republic of China, Beijing              中国人民共和国, 北京
Mobile: +86 13611014044                         手机:+86 13611014044